[lldb] Thread mangling flavor together with node pointer #9496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
force-pushed
the
embedded-node
branch
from
46cedf4 to
f27a408
Compare
LLDB performs many analysis as transformations by converting a mangled name into a demangle tree and later on back to a mangled name. Unfortunately there's no cheap way for a demangle tree to carry its mangled name's mangling flavor. This patch threads the mangling flavor along with the demangle tree so when converting a demangle tree back to a mangled name we reconstruct it with the same mangling flavor as the original type.
augusto2112
force-pushed
the
embedded-node
branch
from
f27a408 to
2cb73cd
Compare
Author
|
@swift-ci test |
augusto2112
changed the title
|
@swift-ci test Windows platform |
1 similar comment
|
@swift-ci test Windows platform |
|
I have one rather fundamental question. Instead of threading this through as a parameter, should embedded Swift be a separate Language with a separate TypeSystemSwift instance (that uses the same implementation, but hardcodes the flavor)? |
|
@swift-ci test |
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.